Bug 229431 - Add support for new pseudo-selectors for media from CSS Selectors Level 4.
Summary: Add support for new pseudo-selectors for media from CSS Selectors Level 4.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-23 15:55 PDT by Jer Noble
Modified: 2022-02-10 16:13 PST (History)
14 users (show)

See Also:


Attachments
Patch (31.33 KB, patch)
2021-08-23 16:01 PDT, Jer Noble
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (32.09 KB, patch)
2021-08-23 17:07 PDT, Jer Noble
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (32.09 KB, patch)
2021-08-23 17:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-08-23 15:55:32 PDT
Add support for new pseudo-selectors for media from CSS Selectors Level 4.
Comment 1 Jer Noble 2021-08-23 16:01:27 PDT
Created attachment 436245 [details]
Patch
Comment 2 Eric Carlson 2021-08-23 16:30:57 PDT
Comment on attachment 436245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436245&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3874
> +    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA && m_sentStalledEvent;

Don't you need to call `invalidateStyle()` when m_sentStalledEvent changes in `progressEventTimerFired()`
Comment 3 Jer Noble 2021-08-23 17:07:22 PDT
Created attachment 436252 [details]
Patch for landing
Comment 4 Jer Noble 2021-08-23 17:11:13 PDT
Created attachment 436253 [details]
Patch for landing
Comment 5 EWS 2021-08-24 11:30:08 PDT
Committed r281503 (240876@main): <https://commits.webkit.org/240876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436253 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-24 11:32:01 PDT
<rdar://problem/82301750>