Bug 229427 – URL's protocol setter should forbid switching non-special to special schemes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

URL.protocol setter should forbid switching between special and non-special schemes

[Alex Christensen]

Created attachment 436239 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/82549495>

[Karl Dubost]

This seems to be a low hanging fruit. 
And that would fix some of the failing tests in
https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=safari%3Afail%20chrome%3Afail%20firefox%3Apass

[Anne van Kesteren]

https://github.com/whatwg/url/issues/674 ended up being filed later in the year so we'll have to be cautious with this one. Might be good if other browsers tackle this first.

Or we could push a specification change, but the alternative solution isn't exactly great.

[Karl Dubost]

So Firefox shipped this first, and they got in two months a first webcompat bug report.

https://github.com/whatwg/url/issues/674#issuecomment-1701304722
https://bugzilla.mozilla.org/show_bug.cgi?id=1850954

Chrome has fixed it (but will be shipped for 118 in ~5 weeks)
https://bugs.chromium.org/p/chromium/issues/detail?id=1416018 (Chrome 118).

[Sam Sneddon [:gsnedders]]

(In reply to Karl Dubost from comment #5)
> Chrome has fixed it (but will be shipped for 118 in ~5 weeks)
> https://bugs.chromium.org/p/chromium/issues/detail?id=1416018 (Chrome 118).

Chrome doesn't seem to have fixed all of this: https://wpt.fyi/results/url?q=url-setters.any.html%20chrome%3Afail&run_id=5155945099558912&run_id=5184649641066496&run_id=5099368770437120

[Sam Sneddon [:gsnedders]]

(In reply to Karl Dubost from comment #5)
> So Firefox shipped this first, and they got in two months a first webcompat
> bug report.
> 
> https://github.com/whatwg/url/issues/674#issuecomment-1701304722
> https://bugzilla.mozilla.org/show_bug.cgi?id=1850954

Note that they reverted it, before re-landing in https://bugzilla.mozilla.org/show_bug.cgi?id=1851426. (Which shipped in Firefox 120, release November 2023.)

[Anne van Kesteren]

Pull request: https://github.com/WebKit/WebKit/pull/42594

[EWS]

Committed 292443@main (0b3fe21c3dfc): <https://commits.webkit.org/292443@main>

Reviewed commits have been landed. Closing PR #42594 and removing active labels.