Bug 229427 - URL.protocol setter should forbid switching between special and non-special schemes
Summary: URL.protocol setter should forbid switching between special and non-special s...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 260854
Blocks: 128023
  Show dependency treegraph
 
Reported: 2021-08-23 15:09 PDT by Alex Christensen
Modified: 2023-08-31 16:25 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.86 KB, patch)
2021-08-23 15:11 PDT, Alex Christensen
achristensen: review-
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-08-23 15:09:10 PDT
URL.protocol setter should forbid switching between special and non-special schemes
Comment 1 Alex Christensen 2021-08-23 15:11:53 PDT
Created attachment 436239 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-08-30 15:10:29 PDT
<rdar://problem/82549495>
Comment 3 Karl Dubost 2023-08-17 02:07:11 PDT
This seems to be a low hanging fruit. 
And that would fix some of the failing tests in
https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=safari%3Afail%20chrome%3Afail%20firefox%3Apass
Comment 4 Anne van Kesteren 2023-08-18 03:06:05 PDT
https://github.com/whatwg/url/issues/674 ended up being filed later in the year so we'll have to be cautious with this one. Might be good if other browsers tackle this first.

Or we could push a specification change, but the alternative solution isn't exactly great.
Comment 5 Karl Dubost 2023-08-31 16:16:08 PDT
So Firefox shipped this first, and they got in two months a first webcompat bug report.

https://github.com/whatwg/url/issues/674#issuecomment-1701304722
https://bugzilla.mozilla.org/show_bug.cgi?id=1850954

Chrome has fixed it (but will be shipped for 118 in ~5 weeks)
https://bugs.chromium.org/p/chromium/issues/detail?id=1416018 (Chrome 118).