Bug 229426 - De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint
Summary: De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA unt...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-23 15:01 PDT by Jer Noble
Modified: 2021-08-30 15:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.17 KB, patch)
2021-08-23 15:12 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-08-23 15:01:36 PDT 
De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint
Comment 1 Jer Noble 2021-08-23 15:12:59 PDT 
Created attachment 436240 [details]
Patch
Comment 2 Eric Carlson 2021-08-23 15:25:22 PDT 
Comment on attachment 436240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436240&action=review

> Source/WebCore/ChangeLog:27
> +        a RGB image.

s/a/an/

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:569
> +                // progress to LikelyToKeepUp. Set the readyState to  HAVE_ENOUGH_DATA, on the

Nit: extra space between "to" and "HAVE_ENOUGH_DATA"

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:591
> +            // Do not allow us to progress  beyond HaveMetadata until the layer is ready for display

Nit: extra space between "progress" and "beyond"
Comment 3 Radar WebKit Bug Importer 2021-08-30 15:02:17 PDT 
<rdar://problem/82549071>