Bug 229392 - The simple text codepath does not handle unpaired surrogates
Summary: The simple text codepath does not handle unpaired surrogates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 206208
  Show dependency tree / graph
 
Reported: 2021-08-23 00:32 PDT by Myles C. Maxfield
Modified: 2024-03-26 15:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (13.47 KB, patch)
2021-08-23 00:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.96 KB, patch)
2021-08-23 00:39 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (16.44 KB, patch)
2021-08-23 01:22 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.45 KB, patch)
2021-08-23 01:27 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (23.66 KB, patch)
2021-08-27 01:05 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-08-23 00:32:42 PDT 
The simple text codepath does not handle unpaired surrogates
Comment 1 Myles C. Maxfield 2021-08-23 00:34:26 PDT 
Created attachment 436156 [details]
Patch
Comment 2 Myles C. Maxfield 2021-08-23 00:39:00 PDT 
Created attachment 436157 [details]
Patch
Comment 3 Myles C. Maxfield 2021-08-23 00:49:44 PDT 
Comment on attachment 436156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review

> Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:60
>      bool consumeSlowCase(UChar32&, unsigned&);

This should be deleted
Comment 4 Myles C. Maxfield 2021-08-23 01:00:56 PDT 
Comment on attachment 436156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review

> Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:22
>  #ifndef SurrogatePairAwareTextIterator_h
>  #define SurrogatePairAwareTextIterator_h

I can probably do #pragma once too
Comment 5 Myles C. Maxfield 2021-08-23 01:06:40 PDT 
It looks like there are some usages of SurrogatePairAwareTextIterator outside of the Cocoa ports.
Comment 6 Myles C. Maxfield 2021-08-23 01:22:53 PDT 
Created attachment 436161 [details]
Patch
Comment 7 Myles C. Maxfield 2021-08-23 01:27:00 PDT 
Created attachment 436162 [details]
Patch
Comment 8 Myles C. Maxfield 2021-08-27 01:05:23 PDT 
Created attachment 436611 [details]
Patch
Comment 9 EWS 2021-08-27 20:20:27 PDT 
Committed r281731 (241073@main): <https://commits.webkit.org/241073@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436611 [details].
Comment 10 Radar WebKit Bug Importer 2021-08-27 20:21:17 PDT 
<rdar://problem/82465705>