Bug 229371 - [JSC] Remove Intl runtime feature flags for already shipped ones
Summary: [JSC] Remove Intl runtime feature flags for already shipped ones
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-21 14:25 PDT by Yusuke Suzuki
Modified: 2021-08-21 17:28 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.71 KB, patch)
2021-08-21 14:25 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.38 KB, patch)
2021-08-21 14:28 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-08-21 14:25:21 PDT 
[JSC] Remove Intl runtime feature flags for already shipped ones
Comment 1 Yusuke Suzuki 2021-08-21 14:25:55 PDT 
Created attachment 436084 [details]
Patch
Comment 2 Yusuke Suzuki 2021-08-21 14:28:03 PDT 
Created attachment 436085 [details]
Patch
Comment 3 Ross Kirsling 2021-08-21 14:43:38 PDT 
Comment on attachment 436085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436085&action=review

r=me with a comment

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Remove Intl runtime feature flags for already shipped ones

Seems like this should be retitled since there's exactly one.
Comment 4 Yusuke Suzuki 2021-08-21 16:39:57 PDT 
Comment on attachment 436085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436085&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] Remove Intl runtime feature flags for already shipped ones
> 
> Seems like this should be retitled since there's exactly one.

Ah, there are two flags useIntlDateTimeFormatDayPeriod and useIntlDateTimeFormatRangeToParts :)
Comment 5 EWS 2021-08-21 17:27:01 PDT 
Committed r281383 (240798@main): <https://commits.webkit.org/240798@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436085 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-21 17:28:17 PDT 
<rdar://problem/82208868>