Bug 229368 - Use an ObjectIdentifier<> type for policy listener IDs
Summary: Use an ObjectIdentifier<> type for policy listener IDs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2021-08-21 12:24 PDT by Simon Fraser (smfr)
Modified: 2021-08-28 12:25 PDT (History)
6 users (show)

See Also:

Patch (31.17 KB, patch)
2021-08-21 12:26 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (33.33 KB, patch)
2021-08-24 18:03 PDT, Simon Fraser (smfr)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-08-21 12:24:52 PDT
Use an ObjectIdentifier<> type for policy listener IDs
Comment 1 Simon Fraser (smfr) 2021-08-21 12:26:23 PDT
Created attachment 436079 [details]
Comment 2 Anders Carlsson 2021-08-23 07:52:39 PDT
Comment on attachment 436079 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=436079&action=review

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:216
> +static uint64_t generateListenerID()

Maybe rename this to generateFormListenerID() if that's the only thing it's used for now.
Comment 3 EWS 2021-08-23 08:38:17 PDT
Tools/Scripts/svn-apply failed to apply attachment 436079 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Simon Fraser (smfr) 2021-08-24 18:03:18 PDT
Created attachment 436358 [details]
Comment 5 Radar WebKit Bug Importer 2021-08-28 12:25:14 PDT