Bug 229357 – [macOS] getDisplayMedia should capture at the constrained size if possible

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

Give getDisplayMedia classes enough information to capture at the constrained size if possible, instead of always capturing at the device size and resizing.

[Radar WebKit Bug Importer]

<rdar://problem/82191109>

[Eric Carlson]

Created attachment 436205 [details]
Patch

This won't apply without the changes in https://bugs.webkit.org/show_bug.cgi?id=229142

[Eric Carlson]

Created attachment 437037 [details]
Patch

[youenn fablet]

Comment on attachment 437037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437037&action=review

> Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:57
> +    const IntSize intrinsicSize() const final;

s/const// here and elsewhere

[Eric Carlson]

Created attachment 437057 [details]
Patch for landing

[Darin Adler]

Comment on attachment 437037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437037&action=review

>> Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:57
>> +    const IntSize intrinsicSize() const final;
> 
> s/const// here and elsewhere

The first const, the one that needlessly makes the return value const, not the one after the function name.

[Eric Carlson]

Created attachment 437061 [details]
Patch for landing

[EWS]

Committed r281880 (241210@main): <https://commits.webkit.org/241210@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437061 [details].