Bug 229356 - Use the strongly typed PageGroupIdentifier in place of uint64_t
Summary: Use the strongly typed PageGroupIdentifier in place of uint64_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-20 16:30 PDT by Simon Fraser (smfr)
Modified: 2021-08-22 08:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (21.60 KB, patch)
2021-08-20 16:31 PDT, Simon Fraser (smfr) 		achristensen: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.45 KB, patch)
2021-08-20 16:38 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-08-20 16:30:05 PDT 
Use the strongly typed PageGroupIdentifier in place of uint64_t
Comment 1 Simon Fraser (smfr) 2021-08-20 16:31:40 PDT 
Created attachment 436041 [details]
Patch
Comment 2 Alex Christensen 2021-08-20 16:34:45 PDT 
Comment on attachment 436041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436041&action=review

> Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.h:48
> +    // Namespace IDs for local storage namespaces are equivalent to web page group IDs.

I would update this to "currently equivalent" because I think we intend to change this once we completely remove WebPageGroup/WebPageGroupProxy.

> Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:56
> +    // Namespace IDs for local storage namespaces are equivalent to web page group IDs.

ditto
Comment 3 Simon Fraser (smfr) 2021-08-20 16:38:35 PDT 
Created attachment 436042 [details]
Patch
Comment 4 EWS 2021-08-22 08:36:00 PDT 
Committed r281398 (240806@main): <https://commits.webkit.org/240806@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436042 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-22 08:36:18 PDT 
<rdar://problem/82218164>