And also fix a minor LLInt code alignment bug.
<rdar://problem/82163923>
Created attachment 435966 [details] proposed patch.
Comment on attachment 435966 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=435966&action=review r=me with nits > Source/JavaScriptCore/ChangeLog:10 > + file from /usr/local/include/WebKitAdditions/ first. If the specified file is Nit: This is technically <build-products>/usr/local/include/WebKitAdditions. > Source/JavaScriptCore/offlineasm/parser.rb:266 > + @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR']; Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake doesn't set that environment variable.
Thanks for the review. (In reply to Keith Miller from comment #3) > > Source/JavaScriptCore/ChangeLog:10 > > + file from /usr/local/include/WebKitAdditions/ first. If the specified file is > > Nit: This is technically <build-products>/usr/local/include/WebKitAdditions. Fixed. > > Source/JavaScriptCore/offlineasm/parser.rb:266 > > + @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR']; > > Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake > doesn't set that environment variable. Done. Ref: https://bugs.webkit.org/show_bug.cgi?id=229340
Landed in r281321: <http://trac.webkit.org/r281321>.
Re-opened since this is blocked by bug 229449
Re-landed in r281541: <http://trac.webkit.org/r281541>.