Bug 229332 – Add some offlineasm enhancements.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

And also fix a minor LLInt code alignment bug.

[Radar WebKit Bug Importer]

<rdar://problem/82163923>

[Mark Lam]

Created attachment 435966 [details]
proposed patch.

[Keith Miller]

Comment on attachment 435966 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=435966&action=review

r=me with nits

> Source/JavaScriptCore/ChangeLog:10
> +           file from /usr/local/include/WebKitAdditions/ first.  If the specified file is

Nit: This is technically <build-products>/usr/local/include/WebKitAdditions.

> Source/JavaScriptCore/offlineasm/parser.rb:266
> +        @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR'];

Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake doesn't set that environment variable.

[Mark Lam]

Thanks for the review.

(In reply to Keith Miller from comment #3)
> > Source/JavaScriptCore/ChangeLog:10
> > +           file from /usr/local/include/WebKitAdditions/ first.  If the specified file is
> 
> Nit: This is technically <build-products>/usr/local/include/WebKitAdditions.

Fixed.

> > Source/JavaScriptCore/offlineasm/parser.rb:266
> > +        @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR'];
> 
> Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake
> doesn't set that environment variable.

Done.  Ref: https://bugs.webkit.org/show_bug.cgi?id=229340

[Mark Lam]

Landed in r281321: <http://trac.webkit.org/r281321>.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 229449

[Mark Lam]

Re-landed in r281541: <http://trac.webkit.org/r281541>.