Bug 229329 - Remove assertIsTagged and assertIsNullOrTagged.
Summary: Remove assertIsTagged and assertIsNullOrTagged.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-20 02:30 PDT by Mark Lam
Modified: 2021-08-20 08:53 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (2.72 KB, patch)
2021-08-20 02:45 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-08-20 02:30:13 PDT 
These assertion utility functions relies on tagged pointers always having non-zero PAC bits.  This is an incorrect assumption.  A tagged pointer can have PAC bits that are completely zero.  Hence, these assert functions cannot be made to work reliably.  We should remove them to prevent them from being used, and potentially resulting in flaky assertion failures that will hard to debug later.
Comment 1 Radar WebKit Bug Importer 2021-08-20 02:30:40 PDT 
<rdar://problem/82162851>
Comment 2 Mark Lam 2021-08-20 02:45:09 PDT 
Created attachment 435963 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2021-08-20 02:50:57 PDT 
Comment on attachment 435963 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2021-08-20 08:25:05 PDT 
Comment on attachment 435963 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-08-20 08:53:22 PDT 
Committed r281317 (240734@main): <https://commits.webkit.org/240734@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435963 [details].