Bug 229328 - Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.
Summary: Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-20 02:04 PDT by Mark Lam
Modified: 2021-08-20 08:56 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (2.08 KB, patch)
2021-08-20 02:09 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-08-20 02:04:57 PDT 
If ptrTagName and tagForPtr are defined, make them WTF_EXPORT_PRIVATE instead of static functions.  This allows us to call them from the debugger during interactive debugging sessions.
Comment 1 Mark Lam 2021-08-20 02:09:17 PDT 
Created attachment 435956 [details]
proposed patch.
Comment 2 Radar WebKit Bug Importer 2021-08-20 02:09:48 PDT 
<rdar://problem/82162395>
Comment 3 Yusuke Suzuki 2021-08-20 02:16:42 PDT 
Comment on attachment 435956 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2021-08-20 08:24:12 PDT 
Comment on attachment 435956 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-08-20 08:56:14 PDT 
Committed r281318 (240735@main): <https://commits.webkit.org/240735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435956 [details].