RESOLVED FIXED 229320
MediaSession artwork URL is showing in logs. 
https://bugs.webkit.org/show_bug.cgi?id=229320
Summary MediaSession artwork URL is showing in logs.
Jean-Yves Avenard [:jya]
Reported 2021-08-19 18:45:49 PDT
We show the MediaSession artwork URL if any is present in the log. We shouldn't
Attachments
Patch (1.99 KB, patch)
2021-08-19 21:49 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2021-08-23 22:50 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-19 21:47:21 PDT
<rdar://problem/82156288>
Jean-Yves Avenard [:jya]
Comment 2 2021-08-19 21:49:30 PDT
Created attachment 435939 [details] Patch
youenn fablet
Comment 3 2021-08-20 09:10:14 PDT
Comment on attachment 435939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393 > - I would tend to keep this logging but remove some information like title and src then.
Eric Carlson
Comment 4 2021-08-20 09:25:23 PDT
Comment on attachment 435939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:392 > +#ifdef DEBUG `#ifndef LOG_DISABLED` would be better I think. >> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393 >> - > > I would tend to keep this logging but remove some information like title and src then. I agree, just drop the url when LOG_DISABLED
Jean-Yves Avenard [:jya]
Comment 5 2021-08-23 22:50:25 PDT
Created attachment 436264 [details] Patch apply comment
EWS
Comment 6 2021-08-24 17:07:33 PDT
Committed r281533 (240904@main): <https://commits.webkit.org/240904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436264 [details].
Note You need to log in before you can comment on or make changes to this bug.