Bug 229294 - [LFC][Integration] Start using InlineInvalidation to clean runs and lines
Summary: [LFC][Integration] Start using InlineInvalidation to clean runs and lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-19 09:55 PDT by zalan
Modified: 2021-09-17 09:10 PDT (History)
15 users (show)

See Also:


Attachments
Patch (7.01 KB, patch)
2021-08-19 09:57 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2021-09-14 16:23 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2021-09-14 16:41 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (14.18 KB, patch)
2021-09-16 18:21 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.82 KB, patch)
2021-09-17 07:32 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-08-19 09:55:51 PDT
we are still not doing any incremental invalidation yet.
Comment 1 zalan 2021-08-19 09:57:20 PDT
Created attachment 435876 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-08-26 09:56:42 PDT
<rdar://problem/82395169>
Comment 3 zalan 2021-09-14 16:23:55 PDT
Created attachment 438186 [details]
Patch
Comment 4 zalan 2021-09-14 16:41:41 PDT
Created attachment 438190 [details]
Patch
Comment 5 zalan 2021-09-16 18:21:37 PDT
Created attachment 438426 [details]
Patch
Comment 6 Antti Koivisto 2021-09-17 06:47:39 PDT
Comment on attachment 438426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438426&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:2149
> +        ASSERT(oldStyle);

maybe these asserts are not needed?
Comment 7 zalan 2021-09-17 07:32:59 PDT
Created attachment 438474 [details]
Patch
Comment 8 EWS 2021-09-17 08:03:19 PDT
Committed r282662 (241803@main): <https://commits.webkit.org/241803@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438474 [details].