Bug 229292 - Add support for RTCSctpTransport
Summary: Add support for RTCSctpTransport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 229977
Blocks:
  Show dependency tree / graph
 
Reported: 2021-08-19 09:34 PDT by youenn fablet
Modified: 2021-09-09 00:13 PDT (History)
23 users (show)

See Also:

Attachments
Patch (80.24 KB, patch)
2021-08-31 06:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (84.15 KB, patch)
2021-09-02 06:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (85.34 KB, patch)
2021-09-05 23:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (85.39 KB, patch)
2021-09-05 23:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fix DTLS test (87.28 KB, patch)
2021-09-06 02:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fix ChangeLog (87.22 KB, patch)
2021-09-06 07:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing more of RTCRtpSender-transport tests (86.82 KB, patch)
2021-09-07 01:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-08-19 09:34:27 PDT 
Add support for RTCSctpTransport
Comment 1 Radar WebKit Bug Importer 2021-08-26 09:35:24 PDT 
<rdar://problem/82394152>
Comment 2 youenn fablet 2021-08-31 06:23:38 PDT 
Created attachment 436880 [details]
Patch
Comment 3 youenn fablet 2021-09-02 06:26:39 PDT 
Created attachment 437143 [details]
Patch
Comment 4 youenn fablet 2021-09-02 08:55:39 PDT 
Comment on attachment 437143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437143&action=review

> Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp:3
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

Need to change this.
Comment 5 youenn fablet 2021-09-05 23:44:30 PDT 
Created attachment 437390 [details]
Patch for landing
Comment 6 youenn fablet 2021-09-05 23:45:29 PDT 
Created attachment 437391 [details]
Patch for landing
Comment 7 youenn fablet 2021-09-06 02:41:42 PDT 
Created attachment 437400 [details]
Fix DTLS test
Comment 8 youenn fablet 2021-09-06 02:42:43 PDT 
(In reply to youenn fablet from comment #7)
> Created attachment 437400 [details]
> Fix DTLS test

DTLS test was failing due to a more accurate connection state computation.
Given we now have pc.sctp.transport.state being exposed, we should directly check this state to validate DTLS fails in case of bad handshake.
Comment 9 EWS 2021-09-06 07:16:44 PDT 
ChangeLog entry in LayoutTests/ChangeLog is not at the top of the file.
Comment 10 youenn fablet 2021-09-06 07:47:39 PDT 
Created attachment 437414 [details]
Fix ChangeLog
Comment 11 EWS 2021-09-06 09:14:42 PDT 
Committed r282057 (241357@main): <https://commits.webkit.org/241357@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437414 [details].
Comment 12 Aakash Jain 2021-09-06 17:02:57 PDT 
(In reply to EWS from comment #11)
> Committed r282057 (241357@main): <https://commits.webkit.org/241357@main>
This seems to have made this layout test extremely flaky: imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html
Comment 13 Aakash Jain 2021-09-06 17:14:11 PDT 
This is slowing down EWS and commit-queue, so I am going to revert it.
Comment 14 WebKit Commit Bot 2021-09-06 17:14:35 PDT 
Re-opened since this is blocked by bug 229977
Comment 15 youenn fablet 2021-09-07 01:09:18 PDT 
Created attachment 437463 [details]
Fixing more of RTCRtpSender-transport tests
Comment 16 youenn fablet 2021-09-07 01:10:17 PDT 
(In reply to Aakash Jain from comment #12)
> (In reply to EWS from comment #11)
> > Committed r282057 (241357@main): <https://commits.webkit.org/241357@main>
> This seems to have made this layout test extremely flaky:
> imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html

This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=229931
Comment 17 EWS 2021-09-09 00:13:36 PDT 
Committed r282197 (241484@main): <https://commits.webkit.org/241484@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437463 [details].