Bug 229288 - [run-webkit-tests] Handle json crash logs
Summary: [run-webkit-tests] Handle json crash logs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-19 08:30 PDT by Jonathan Bedard
Modified: 2021-08-19 12:46 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2021-08-19 08:33 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2021-08-19 08:55 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2021-08-19 11:39 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-08-19 08:30:05 PDT 
Starting in Monterey, .ips crash logs are JSON encoded in macOS.  run-webkit-tests needs to handle this.
Comment 1 Jonathan Bedard 2021-08-19 08:30:22 PDT 
<rdar://problem/77074039>
Comment 2 Jonathan Bedard 2021-08-19 08:33:08 PDT 
Created attachment 435861 [details]
Patch
Comment 3 Jonathan Bedard 2021-08-19 08:55:35 PDT 
Created attachment 435864 [details]
Patch
Comment 4 Alexey Proskuryakov 2021-08-19 09:22:40 PDT 
This code would benefit from unit testing, as we want to support multiple format and multiple kinds of logs (distinguishing crashes and sandbox violations).
Comment 5 Jonathan Bedard 2021-08-19 11:39:52 PDT 
Created attachment 435888 [details]
Patch
Comment 6 Jonathan Bedard 2021-08-19 11:41:42 PDT 
(In reply to Jonathan Bedard from comment #5)
> Created attachment 435888 [details]
> Patch

Added a json crash log to our unit testing.
Comment 7 EWS 2021-08-19 12:46:08 PDT 
Committed r281257 (240692@main): <https://commits.webkit.org/240692@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435888 [details].