RESOLVED FIXED 229288
[run-webkit-tests] Handle json crash logs
https://bugs.webkit.org/show_bug.cgi?id=229288
Summary [run-webkit-tests] Handle json crash logs
Jonathan Bedard
Reported 2021-08-19 08:30:05 PDT
Starting in Monterey, .ips crash logs are JSON encoded in macOS. run-webkit-tests needs to handle this.
Attachments
Patch (2.63 KB, patch)
2021-08-19 08:33 PDT, Jonathan Bedard
no flags
Patch (2.63 KB, patch)
2021-08-19 08:55 PDT, Jonathan Bedard
no flags
Patch (6.34 KB, patch)
2021-08-19 11:39 PDT, Jonathan Bedard
no flags
Jonathan Bedard
Comment 1 2021-08-19 08:30:22 PDT
Jonathan Bedard
Comment 2 2021-08-19 08:33:08 PDT
Jonathan Bedard
Comment 3 2021-08-19 08:55:35 PDT
Alexey Proskuryakov
Comment 4 2021-08-19 09:22:40 PDT
This code would benefit from unit testing, as we want to support multiple format and multiple kinds of logs (distinguishing crashes and sandbox violations).
Jonathan Bedard
Comment 5 2021-08-19 11:39:52 PDT
Jonathan Bedard
Comment 6 2021-08-19 11:41:42 PDT
(In reply to Jonathan Bedard from comment #5) > Created attachment 435888 [details] > Patch Added a json crash log to our unit testing.
EWS
Comment 7 2021-08-19 12:46:08 PDT
Committed r281257 (240692@main): <https://commits.webkit.org/240692@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435888 [details].
Note You need to log in before you can comment on or make changes to this bug.