Touchbar not showing time scrubbing
rdar://81349236
Created attachment 435859 [details] Patch
Comment on attachment 435859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435859&action=review > Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:93 > ++ (NSSet<NSString *> *)keyPathsForValuesAffectingCanSeek > +{ > + return [NSSet setWithObject:@"seekableTimeRanges"]; > +} > + Nit: I would put this right above -(BOOL)canSeek, rather than next to seekableTimeRanges.
Comment on attachment 435859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435859&action=review >> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:93 >> + > > Nit: I would put this right above -(BOOL)canSeek, rather than next to seekableTimeRanges. there's no canSeek method, it's a synthesised property. But I'll move it above.
Created attachment 435932 [details] Patch
Committed r281288 (240712@main): <https://commits.webkit.org/240712@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435932 [details].
Comment on attachment 435932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435932&action=review > Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:139 > + return [NSSet setWithObjects:@"canSeek", "contentDuration", nil]; Did you mean `@"contentDuration"`?
Reopening to attach new patch.
Created attachment 436005 [details] Patch
Committed r281334 (240751@main): <https://commits.webkit.org/240751@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436005 [details].
Oops How did that compile locally I wonder.