Bug 229267 - WebGL via Metal experimental feature does not correctly toggle metal backend
Summary: WebGL via Metal experimental feature does not correctly toggle metal backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-18 17:56 PDT by Kyle Piddington
Modified: 2021-08-19 09:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2021-08-18 17:59 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (12.57 KB, patch)
2021-08-18 20:40 PDT, Kyle Piddington 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS test (9.75 KB, patch)
2021-08-19 09:25 PDT, Dean Jackson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-08-18 17:56:59 PDT 
WebGL via Metal experimental feature does not correctly toggle metal backend
Comment 1 Kyle Piddington 2021-08-18 17:59:08 PDT 
Created attachment 435824 [details]
Patch
Comment 2 Dean Jackson 2021-08-18 18:13:48 PDT 
We should be able to write a test for this.

It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.
Comment 3 Dean Jackson 2021-08-18 18:13:56 PDT 
We should be able to write a test for this.

It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.
Comment 4 Dean Jackson 2021-08-18 18:17:26 PDT 
<!-- webkit-test-runner [ WebGLUsingMetal=false ] →

should turn it off for a specific test
Comment 5 Dean Jackson 2021-08-18 18:27:14 PDT 
Sorry, I meant https://trac.webkit.org/changeset/281124
Comment 6 Kyle Piddington 2021-08-18 20:40:11 PDT 
Created attachment 435835 [details]
Patch
Comment 7 Dean Jackson 2021-08-19 09:15:06 PDT 
Comment on attachment 435835 [details]
Patch

r=me but we'll remove the Metal.framework from Xcode when landing.
Comment 8 Dean Jackson 2021-08-19 09:25:58 PDT 
Created attachment 435872 [details]
EWS test
Comment 9 Dean Jackson 2021-08-19 09:28:25 PDT 
Committed r281245 (240682@main): <https://commits.webkit.org/240682@main>
Comment 10 Radar WebKit Bug Importer 2021-08-19 09:29:16 PDT 
<rdar://problem/82128791>