Bug 229236 - Do not terminate relaunched network process when getting network process connection
Summary: Do not terminate relaunched network process when getting network process conn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-18 09:15 PDT by Sihui Liu
Modified: 2021-08-18 10:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2021-08-18 09:27 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.66 KB, patch)
2021-08-18 10:19 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-08-18 09:15:50 PDT 
...
Comment 1 Sihui Liu 2021-08-18 09:27:31 PDT 
Created attachment 435774 [details]
Patch
Comment 2 Chris Dumez 2021-08-18 09:53:15 PDT 
Comment on attachment 435774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762
> +                    if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get())

Do we really need the ".get()" on either side? It should be OK to == RefPtrs.
Comment 3 Sihui Liu 2021-08-18 10:18:15 PDT 
Comment on attachment 435774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762
>> +                    if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get())
> 
> Do we really need the ".get()" on either side? It should be OK to == RefPtrs.

It seems we only need one .get(), will update.
Comment 4 Sihui Liu 2021-08-18 10:19:27 PDT 
Created attachment 435781 [details]
Patch for landing
Comment 5 EWS 2021-08-18 10:45:36 PDT 
Committed r281199 (240643@main): <https://commits.webkit.org/240643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435781 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-18 10:46:18 PDT 
<rdar://problem/82084469>