Bug 229232 - [git-webkit] "IndexError: list index out of range" using log
Summary: [git-webkit] "IndexError: list index out of range" using log
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-18 03:21 PDT by Sergio Villar Senin
Modified: 2021-08-18 10:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2021-08-18 09:40 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-08-18 03:21:56 PDT
This is the full backtrace:

$ Tools/Scripts/git-webkit log
Traceback (most recent call last):
  File "~/WebKit/Tools/Scripts/git-webkit", line 45, in <module>
    sys.exit(program.main(
  File "~/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 92, in main
    return parsed.main(
  File "~/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py", line 40, in main
    return cls.pager(args, repository, file=__file__, **kwargs)
  File "~/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py", line 125, in pager
    more = subprocess.Popen([which('more')] + ['-F', '-R'] if platform.system() == 'Darwin' else [], stdin=child.stdout)
  File "/usr/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.9/subprocess.py", line 1693, in _execute_child
    executable = args[0]
IndexError: list index out of range

I'm on a Linux machine BTW
Comment 1 Jonathan Bedard 2021-08-18 09:40:21 PDT
Created attachment 435775 [details]
Patch
Comment 2 Jonathan Bedard 2021-08-18 09:40:56 PDT
This is a silly bug that happened because I don't do enough testing on non-Mac platforms.
Comment 3 EWS 2021-08-18 10:19:30 PDT
Committed r281197 (240641@main): <https://commits.webkit.org/240641@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435775 [details].
Comment 4 Radar WebKit Bug Importer 2021-08-18 10:20:26 PDT
<rdar://problem/82083191>