Bug 229207 - REBASELINE [ iOS ] 3X imported/w3c/web-platform-tests/css/css-typed-om layout-tests are constant text failures
Summary: REBASELINE [ iOS ] 3X imported/w3c/web-platform-tests/css/css-typed-om layout...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-17 14:55 PDT by Robert Jenner
Modified: 2021-09-02 12:12 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-08-17 14:55:40 PDT
The following three imported/w3c/web-platform-tests/css/css-typed-om layout-tests are constant text failures on iOS:

imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle.html
imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em.html
imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em.html

HISTORY
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-typed-om%2Frotate-by-added-angle.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-typed-om%2Fwidth-by-max-px-em.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-typed-om%2Fwidth-by-min-px-em.html

DIFF URLS:
https://build.webkit.org/results/Apple-iPadOS-14-Simulator-Release-WK2-Tests/r281147%20(1822)/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-diff.txt
https://build.webkit.org/results/Apple-iPadOS-14-Simulator-Release-WK2-Tests/r281147%20(1822)/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-diff.txt
https://build.webkit.org/results/Apple-iPadOS-14-Simulator-Release-WK2-Tests/r281147%20(1822)/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-diff.txt

DIFF TEXT for "imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle.html":
 CONSOLE MESSAGE: ReferenceError: Can't find variable: CSSMathSum
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x50
-  RenderBlock {HTML} at (0,0) size 800x50
-    RenderBody {BODY} at (8,16) size 784x18
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 323x18
-          text run at (0,0) width 323: "Test passes if there is a filled green rectangle with "
-        RenderInline {STRONG} at (0,0) size 45x18
-          RenderText {#text} at (322,0) size 45x18
-            text run at (322,0) width 45: "no red"
-        RenderText {#text} at (366,0) size 5x18
+layer at (0,0) size 800x52
+  RenderBlock {HTML} at (0,0) size 800x52
+    RenderBody {BODY} at (8,16) size 784x20
+      RenderBlock {P} at (0,0) size 784x20
+        RenderText {#text} at (0,0) size 324x19
+          text run at (0,0) width 324: "Test passes if there is a filled green rectangle with "
+        RenderInline {STRONG} at (0,0) size 44x19
+          RenderText {#text} at (323,0) size 44x19
+            text run at (323,0) width 44: "no red"
+        RenderText {#text} at (366,0) size 5x19
           text run at (366,0) width 5: "."
 layer at (100,100) size 200x100
   RenderBlock (positioned) {DIV} at (100,100) size 200x100 [bgcolor=#FF0000]



DIFF TEXT for "imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em.html":
 CONSOLE MESSAGE: ReferenceError: Can't find variable: CSSMathMax
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x158
-  RenderBlock {HTML} at (0,0) size 800x158
-    RenderBody {BODY} at (8,16) size 784x134
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 274x18
+layer at (0,0) size 800x160
+  RenderBlock {HTML} at (0,0) size 800x160
+    RenderBody {BODY} at (8,16) size 784x136
+      RenderBlock {P} at (0,0) size 784x20
+        RenderText {#text} at (0,0) size 274x19
           text run at (0,0) width 274: "Test passes if there is a filled green square."
-      RenderBlock {DIV} at (0,34) size 784x100 [bgcolor=#008000]
+      RenderBlock {DIV} at (0,36) size 784x100 [bgcolor=#008000]


DIFF TEXT for "imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em.html":
 CONSOLE MESSAGE: ReferenceError: Can't find variable: CSSMathMin
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x158
-  RenderBlock {HTML} at (0,0) size 800x158
-    RenderBody {BODY} at (8,16) size 784x134
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 274x18
+layer at (0,0) size 800x160
+  RenderBlock {HTML} at (0,0) size 800x160
+    RenderBody {BODY} at (8,16) size 784x136
+      RenderBlock {P} at (0,0) size 784x20
+        RenderText {#text} at (0,0) size 274x19
           text run at (0,0) width 274: "Test passes if there is a filled green square."
-      RenderBlock {DIV} at (0,34) size 784x100 [bgcolor=#008000]
+      RenderBlock {DIV} at (0,36) size 784x100 [bgcolor=#008000]
Comment 1 Radar WebKit Bug Importer 2021-08-17 14:56:02 PDT
<rdar://problem/82048112>
Comment 2 Robert Jenner 2021-08-17 14:58:05 PDT
It appears these three tests were added recently, and have been constant text failures since. The tests were added here:

https://trac.webkit.org/changeset/281127/webkit
Comment 3 Robert Jenner 2021-08-17 15:26:41 PDT
The failures were easily reproducible on iOS 14 Production ToT using the following test:

run-webkit-tests --ios-simulator <Insert_Test_Here>
Comment 4 Robert Jenner 2021-08-17 15:55:04 PDT
Rebased tests here:
https://trac.webkit.org/changeset/281168/webkit

Will watch to verify rebase was successful.
Comment 5 Alex Christensen 2021-09-02 12:12:39 PDT
Yep, that fixed them.