WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229202
[App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated
https://bugs.webkit.org/show_bug.cgi?id=229202
Summary
[App Privacy Report] Some HTTP Redirects from non app initiated requests are ...
Kate Cheney
Reported
2021-08-17 13:59:24 PDT
Seeing this with media loads only.
Attachments
Patch
(9.14 KB, patch)
2021-08-17 15:41 PDT
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch
(9.35 KB, patch)
2021-08-17 19:14 PDT
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch
(9.43 KB, patch)
2021-08-18 07:59 PDT
,
Kate Cheney
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Kate Cheney
Comment 1
2021-08-17 13:59:45 PDT
<
rdar://problem/79467871
>
Kate Cheney
Comment 2
2021-08-17 15:41:34 PDT
Created
attachment 435718
[details]
Patch
Kate Cheney
Comment 3
2021-08-17 19:14:32 PDT
Created
attachment 435735
[details]
Patch
Kate Cheney
Comment 4
2021-08-18 07:59:21 PDT
Created
attachment 435767
[details]
Patch
Brent Fulgham
Comment 5
2021-08-18 21:37:01 PDT
Comment on
attachment 435767
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=435767&action=review
R=me
> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:617 > + nsRequest = mutableRequest.get();
It would be better if we could initialize attribution when we construct the NSURLRequest from the request above, but this is fine for now.
Kate Cheney
Comment 6
2021-08-19 05:49:25 PDT
Comment on
attachment 435767
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=435767&action=review
>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:617 >> + nsRequest = mutableRequest.get(); > > It would be better if we could initialize attribution when we construct the NSURLRequest from the request above, but this is fine for now.
That's a good idea. It would require changing the ::nsURLRequest function which is used in a lot of places, so agreed it might be better for a separate fix.
EWS
Comment 7
2021-08-19 05:58:06 PDT
Committed
r281234
(
240671@main
): <
https://commits.webkit.org/240671@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 435767
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug