Bug 22919 - Should use consistent algorithm to compute elapsedTime
Summary: Should use consistent algorithm to compute elapsedTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-18 11:14 PST by Chris Marrin
Modified: 2009-03-02 11:51 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2008-12-18 11:17 PST, Chris Marrin
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2008-12-18 11:14:27 PST
KeyframeAnimation::animate() and AnimationBase::progress() both compute elapsedTime differently. This has not caused any visible problems so far. But with the new pauseAnimationAtTimeOnElementWithId() interface could expose problems since the differences are mostly in how they deal with pause. So I need to unify this into a common function
Comment 1 Chris Marrin 2008-12-18 11:17:27 PST
Created attachment 26125 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-01-06 15:05:49 PST
Comment on attachment 26125 [details]
Patch

It appears the behavior or progress() for elapsed times < 0 changes with this patch.  I don't have enough context to tell if that's a good thing or not.
Comment 3 Chris Marrin 2009-01-12 15:45:47 PST
It does change the elapsed time < 0 behavior. When reviewing this I noticed that difference. The current formula is a composite of the two old formulae and I believe the current one does the right thing in all cases. 
Comment 4 Chris Marrin 2009-01-13 14:57:21 PST
Fixed by Changeset 39849