Bug 229188 - Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging
Summary: Remove all WTR output before Content-Type:text/plain for WebRTC tests in case...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 225523 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-08-17 05:53 PDT by youenn fablet
Modified: 2022-02-12 20:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.69 KB, patch)
2021-08-17 06:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-08-17 05:53:27 PDT 
Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging
Comment 1 youenn fablet 2021-08-17 06:05:28 PDT 
Created attachment 435681 [details]
Patch
Comment 2 Jonathan Bedard 2021-08-17 10:17:35 PDT 
Comment on attachment 435681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review

> Tools/Scripts/webkitpy/port/mac.py:-299
> -

Why are you deleting these?
Comment 3 youenn fablet 2021-08-18 00:52:35 PDT 
Comment on attachment 435681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review

>> Tools/Scripts/webkitpy/port/mac.py:-299
>> -
> 
> Why are you deleting these?

They should be covered by Negotiation String and LRP which signal encoder is doing some logging.
These additional lines were attempts to cover the fact encoder logging is being wrapped in multiple lines, but as we see, it does not work well.
Comment 4 EWS 2021-08-20 00:50:26 PDT 
Committed r281297 (240721@main): <https://commits.webkit.org/240721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435681 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-20 00:51:15 PDT 
<rdar://problem/82160516>
Comment 6 youenn fablet 2021-08-20 09:16:20 PDT 
*** Bug 225525 has been marked as a duplicate of this bug. ***
Comment 7 youenn fablet 2021-08-26 05:45:00 PDT 
As can be seen in https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r280628%20(4289)/webrtc/video-setDirection-pretty-diff.html, this is not covering all cases: the underlying codec related logging is sometimes half captured.
Comment 8 youenn fablet 2021-08-26 05:45:45 PDT 
One possibility would be to remove all logging before Content-Type:text/plain in all webrtc tests.
Comment 9 Brent Fulgham 2022-02-12 20:40:07 PST 
*** Bug 225523 has been marked as a duplicate of this bug. ***