Bug 229182 - compressedTexSubImage2D does not return error when COMPRESSED_RGB_ETC1_WEBGL is used
Summary: compressedTexSubImage2D does not return error when COMPRESSED_RGB_ETC1_WEBGL ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-17 02:37 PDT by Kimmo Kinnunen
Modified: 2021-08-31 03:16 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-08-17 02:37:25 PDT 
compressedTexSubImage2D does return error when COMPRESSED_RGB_ETC1_WEBGL is used

Would have been easier to understand the behavior for the developer in bug 229180.
Comment 1 Kimmo Kinnunen 2021-08-17 02:39:03 PDT 
WebGLRenderingContextBase::validateCompressedTexDimensions

  ...

    case ExtensionsGL::ETC1_RGB8_OES:
        // Not supported for ETC1_RGB8_OES textures.
        return false;
Comment 2 Kenneth Russell 2021-08-17 11:10:37 PDT 
Changed summary: "does" -> "does not".
Comment 3 Radar WebKit Bug Importer 2021-08-24 02:38:16 PDT 
<rdar://problem/82283649>
Comment 4 Kimmo Kinnunen 2021-08-31 03:16:22 PDT 
In fact, the unreported error in validateCompressedTexSubDimensions is !USE(ANGLE) block. ANGLE does report INVALID_OPERATION and this should have been observable in the original report should I have understood to add a check for it. (Since it's from ANGLE and not a simulated error, it's not printed in the console).