Bug 22918 - Web Inspector crashes if no node is selected when it is launched (Qt port only)
Summary: Web Inspector crashes if no node is selected when it is launched (Qt port only)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-18 09:42 PST by Yael
Modified: 2008-12-19 00:20 PST (History)
0 users

See Also:

Attachments
When Web Inspector is launched without an associated node, call show() instead of inspect(). (1.17 KB, patch)
2008-12-18 09:43 PST, Yael 		vestbo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2008-12-18 09:42:38 PST 
Web Inspector works fine if launched from a context menu. But if it is launched in any other way it crashes.
Comment 1 Yael 2008-12-18 09:43:53 PST 
Created attachment 26121 [details]
When Web Inspector is launched without an associated node, call show() instead of inspect().
Comment 2 Tor Arne Vestbø 2008-12-19 00:07:02 PST 
Comment on attachment 26121 [details]
When Web Inspector is launched without an associated node, call show() instead of inspect().

Good catch!

> +            if (d->hitTestResult.d)

We can probably use isNull() instead of d directly here. I'll land it with that change.

Thanks!
Comment 3 Tor Arne Vestbø 2008-12-19 00:20:04 PST 
Landed in r39394, added commit message from comment #1 to changelog.