Bug 22917 – break out text selection on initial focus as separate feature

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Cary Clark]

Focusing on a textarea sets the caret at the beginning of the selection. The ANDROID platform user interface guidelines requires selecting all when focusing on a textarea. I'd like a compile-time flag to select this behavior.

[Cary Clark]

Created attachment 26122 [details]
patch to allow selecting all text on initial focus of text area

[Darin Adler]

Comment on attachment 26122 [details]
patch to allow selecting all text on initial focus of text area

> +#if !defined(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL)
> +#define ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL 0
> +#endif

Seems slightly excessive to control this with Platform.h, but I suppose we can refactor this when we refactor Platform.h in the future.

> +        WARNING: NO TEST CASES ADDED OR CHANGED

Please remove this line from the ChangeLog. The warning is to you, the person writing the ChangeLog, and shouldn't be checked in.

The ChangeLog should include the URL of this bug report.

r=me

[Cary Clark]

Created attachment 26431 [details]
patch to allow selecting all text on initial focus of text area

removed WARNING from WebCore ChangeLog; added bug URLs to both ChangeLogs

[Eric Seidel (no email)]

Comment on attachment 26431 [details]
patch to allow selecting all text on initial focus of text area

You seem to have addressed darin's comments, and this otherwise looks fine.

[Eric Seidel (no email)]

Your defined() check did not match what you were defining.  But I fixed the check to ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL when landing.  I'm surprised this patch worked for you.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/wtf/Platform.h
	M	WebCore/ChangeLog
	M	WebCore/html/HTMLTextAreaElement.cpp
Committed r40645

[Eric Seidel (no email)]

Patch was wrong.  Fixed:

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Element.cpp
Committed r40654

[Eric Seidel (no email)]

Sorry, that was destined for bug 23163.