Bug 229160 – [results.webkit.org] Add ability to access Bugzilla and Radar links from commit messages

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kevin Neal]

Find Bugzilla and Radar references in commit messages.

[Kevin Neal]

Created attachment 435690 [details]
Patch

[Jonathan Bedard]

Comment on attachment 435690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435690&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:145
> +        this.bugUrls = json.message.match(/\b(https?):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);

Should probably only have 1 url

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:146
> +        this.radarUrls = json.message.match(/\b(rdar):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);

Have we investigated performance of doing this for every commit instead of on-demand?

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:196
> +                    ${node.label.message ? `<br><div>${linkify(escapeHTML(node.label.message.split('\n')[0]))}</div>` : ''} <hr>${node.label.bugUrls ? `<div>${linkify(escapeHTML(node.label.bugUrls.join(',')))}</div>` : ''}${node.label.radarUrls ? `<div>${linkify(escapeHTML(node.label.radarUrls.join(',')))}</div>` : ''}

We probably don't want the <hr> divider if there are no bug urls, also, this divider should be the inverse color (white in dark mode, black in normal mode)

[Kevin Neal]

Created attachment 435904 [details]
Patch

[Kevin Neal]

Created attachment 435918 [details]
Patch

[Kevin Neal]

Created attachment 435985 [details]
Patch

[Jonathan Bedard]

Comment on attachment 435985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435985&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:146
> +        this.radarUrls = json.message.match(/\b(rdar):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);

The only question remaining here is if we should do this computation in the constructor, or on-demand? There might be a performance hit here.

[Radar WebKit Bug Importer]

<rdar://problem/82260189>

[Ryan Haddad]

(In reply to Jonathan Bedard from comment #6)
> Comment on attachment 435985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435985&action=review
> 
> > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:146
> > +        this.radarUrls = json.message.match(/\b(rdar):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);
> 
> The only question remaining here is if we should do this computation in the
> constructor, or on-demand? There might be a performance hit here.
Kevin, did you manage to find an answer for this question?

[Kevin Neal]

I reviewed the performance of the app with a fully loaded set of commits and it took an average of 0.0119154 milliseconds to run the regexes.

[Kevin Neal]

Created attachment 438527 [details]
Patch

[EWS]

Committed r282717 (241854@main): <https://commits.webkit.org/241854@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438527 [details].