Bug 229140 - Incorrect repaint when inline level box style change triggers line height change
Summary: Incorrect repaint when inline level box style change triggers line height change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-16 07:56 PDT by Tim Nguyen (:ntim)
Modified: 2021-08-17 07:11 PDT (History)
11 users (show)

See Also:


Attachments
Testcase (353 bytes, text/html)
2021-08-16 07:56 PDT, Tim Nguyen (:ntim)
no flags Details
Test reduction (191 bytes, text/html)
2021-08-16 08:08 PDT, zalan
no flags Details
Test reduction (187 bytes, text/html)
2021-08-16 08:11 PDT, zalan
no flags Details
patch (4.63 KB, patch)
2021-08-17 01:29 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-08-16 07:56:54 PDT
Created attachment 435602 [details]
Testcase

hi is displayed twice with the testcase.
Comment 1 Radar WebKit Bug Importer 2021-08-16 07:58:37 PDT
<rdar://problem/81980863>
Comment 2 zalan 2021-08-16 08:08:56 PDT
Created attachment 435603 [details]
Test reduction
Comment 3 zalan 2021-08-16 08:11:10 PDT
Created attachment 435604 [details]
Test reduction
Comment 4 zalan 2021-08-16 08:13:03 PDT
This looks to be timing related too. If you can't repro, try locally (or change the timeout).
Comment 5 Antti Koivisto 2021-08-16 09:51:47 PDT
We fail to repaint the old content area when the block shrinks vertically as a result of a layout. Legacy handles this by invalidating deleted line boxes.

In many real world cases the content below moves, triggering repaint and hiding the issue.
Comment 6 Antti Koivisto 2021-08-17 01:29:00 PDT
Created attachment 435671 [details]
patch
Comment 7 EWS 2021-08-17 07:11:30 PDT
Committed r281136 (240590@main): <https://commits.webkit.org/240590@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435671 [details].