Bug 229138 - Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Summary: Signaling state check when applying a local or remote description is no longe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 229570
Blocks:
  Show dependency tree / graph
 
Reported: 2021-08-16 07:12 PDT by youenn fablet
Modified: 2021-09-03 04:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (38.57 KB, patch)
2021-08-16 07:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (47.12 KB, patch)
2021-08-19 09:09 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (47.59 KB, patch)
2021-08-19 10:11 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (47.83 KB, patch)
2021-08-20 00:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (47.89 KB, patch)
2021-08-26 00:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (45.58 KB, patch)
2021-09-03 02:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-08-16 07:12:11 PDT 
Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Comment 1 youenn fablet 2021-08-16 07:19:49 PDT 
Created attachment 435597 [details]
Patch
Comment 2 youenn fablet 2021-08-19 09:09:32 PDT 
Created attachment 435868 [details]
Patch
Comment 3 youenn fablet 2021-08-19 10:11:42 PDT 
Created attachment 435879 [details]
Patch
Comment 4 Eric Carlson 2021-08-19 11:46:51 PDT 
Comment on attachment 435879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435879&action=review

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:278
> +    default:

It might be better to include the other cases here and leave out `default` so we'll get a compile error if an enum added or removed.

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:310
> +    default:

Ditto
Comment 5 youenn fablet 2021-08-20 00:33:43 PDT 
Created attachment 435947 [details]
Patch for landing
Comment 6 EWS 2021-08-20 01:08:23 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 7 Radar WebKit Bug Importer 2021-08-23 07:13:17 PDT 
<rdar://problem/82243153>
Comment 8 youenn fablet 2021-08-26 00:10:43 PDT 
Created attachment 436476 [details]
Patch for landing
Comment 9 EWS 2021-08-26 00:57:43 PDT 
Committed r281616 (240972@main): <https://commits.webkit.org/240972@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436476 [details].
Comment 10 WebKit Commit Bot 2021-08-26 09:53:02 PDT 
Re-opened since this is blocked by bug 229570
Comment 11 youenn fablet 2021-09-03 02:31:47 PDT 
Created attachment 437254 [details]
Rebasing
Comment 12 EWS 2021-09-03 04:30:24 PDT 
Committed r281985 (241292@main): <https://commits.webkit.org/241292@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437254 [details].