WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229134
[GLib] Enable mediastream setting if it's enabled at build-time
https://bugs.webkit.org/show_bug.cgi?id=229134
Summary
[GLib] Enable mediastream setting if it's enabled at build-time
Philippe Normand
Reported
2021-08-16 04:31:25 PDT
https://bugs.webkit.org/show_bug.cgi?id=217991#c15
:
> My concern here is that these APIs will be public, but they won't do anything in releases until it no longer depends on ${ENABLE_EXPERIMENTAL_FEATURES}. Reminds me of the broken webkit_settings_[g,s]et_media_stream() API, which has been exposed since WebKitGTK 2.4, but has never worked in releases because media stream is still disabled at build time. What I would do instead is enable the setting at runtime so that the public API isn't required for testing it. Then in the future when we're finally ready to enable media session in releases, that's when we would want to add these APIs.
So if this is enabled at build-time, maybe we should enable it by default at runtime? wdyt Michael?
Attachments
Patch
(1.68 KB, patch)
2021-08-16 04:33 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Patch
(3.46 KB, patch)
2021-08-16 08:33 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2021-08-16 04:33:26 PDT
Created
attachment 435589
[details]
Patch
EWS Watchlist
Comment 2
2021-08-16 04:34:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3
2021-08-16 08:18:12 PDT
(In reply to Philippe Normand from
comment #0
)
> So if this is enabled at build-time, maybe we should enable it by default at > runtime? wdyt Michael?
Yes please, this is exactly what I suggested!
Philippe Normand
Comment 4
2021-08-16 08:22:49 PDT
Ah, I forgot to check the API tests.
Philippe Normand
Comment 5
2021-08-16 08:33:26 PDT
Created
attachment 435605
[details]
Patch
EWS
Comment 6
2021-08-16 09:18:53 PDT
Committed
r281085
(
240545@main
): <
https://commits.webkit.org/240545@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 435605
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug