Bug 229134 – [GLib] Enable mediastream setting if it's enabled at build-time

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

https://bugs.webkit.org/show_bug.cgi?id=217991#c15 :

> My concern here is that these APIs will be public, but they won't do anything in releases until it no longer depends on ${ENABLE_EXPERIMENTAL_FEATURES}. Reminds me of the broken webkit_settings_[g,s]et_media_stream() API, which has been exposed since WebKitGTK 2.4, but has never worked in releases because media stream is still disabled at build time. What I would do instead is enable the setting at runtime so that the public API isn't required for testing it. Then in the future when we're finally ready to enable media session in releases, that's when we would want to add these APIs.

So if this is enabled at build-time, maybe we should enable it by default at runtime? wdyt Michael?

[Philippe Normand]

Created attachment 435589 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

(In reply to Philippe Normand from comment #0)
> So if this is enabled at build-time, maybe we should enable it by default at
> runtime? wdyt Michael?

Yes please, this is exactly what I suggested!

[Philippe Normand]

Ah, I forgot to check the API tests.

[Philippe Normand]

Created attachment 435605 [details]
Patch

[EWS]

Committed r281085 (240545@main): <https://commits.webkit.org/240545@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435605 [details].