Bug 229133 - Add support for RTCDtlsTransport
Summary: Add support for RTCDtlsTransport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-16 04:24 PDT by youenn fablet
Modified: 2021-08-19 00:38 PDT (History)
19 users (show)

See Also:

Attachments
Patch (97.35 KB, patch)
2021-08-16 04:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (105.69 KB, patch)
2021-08-16 05:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (103.20 KB, patch)
2021-08-16 05:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (101.45 KB, patch)
2021-08-16 06:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-08-16 04:24:05 PDT 
Add support for RTCDtlsTransport
Comment 1 youenn fablet 2021-08-16 04:28:50 PDT 
Created attachment 435587 [details]
Patch
Comment 2 youenn fablet 2021-08-16 05:26:53 PDT 
Created attachment 435590 [details]
Patch
Comment 3 youenn fablet 2021-08-16 05:27:46 PDT 
Created attachment 435591 [details]
Patch
Comment 4 youenn fablet 2021-08-16 06:50:49 PDT 
Created attachment 435594 [details]
Patch
Comment 5 Eric Carlson 2021-08-16 08:24:57 PDT 
Comment on attachment 435594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435594&action=review

> Source/WebCore/Modules/mediastream/RTCDtlsTransport.cpp:3
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

s/2017/2021/

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp:2
> + * Copyright (C) 2018 Apple Inc.

Ditto.

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h:2
> + * Copyright (C) 2018 Apple Inc.

Ditto

> LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11
> +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"

Do we need a bug for these and the other new/changed test failures?
Comment 6 youenn fablet 2021-08-16 10:08:44 PDT 
Thanks for the review.

> > LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11
> > +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> > +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> > +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> 
> Do we need a bug for these and the other new/changed test failures?

I'll fix it when exposing iceTransport.
Comment 7 EWS 2021-08-19 00:36:59 PDT 
Committed r281225 (240662@main): <https://commits.webkit.org/240662@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435594 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-19 00:38:18 PDT 
<rdar://problem/82113393>