RESOLVED FIXED 229132
Web Share CanShare() should be called after transient activation check
https://bugs.webkit.org/show_bug.cgi?id=229132
Summary Web Share CanShare() should be called after transient activation check
Marcos Caceres
Reported 2021-08-16 02:10:42 PDT
At the moment, Navigator::Share() calls into the CanShare() checks before checking if the page has transient activation. According to the spec [1] - step 4, the transient activation check, and consumption of the transient activation, should happen before calling into CanShare(). [1] https://w3c.github.io/web-share/#share-method That's causing the following test to fail: https://wpt.live/web-share/share-consume-activation.https.html PS: Can we have a "Web Share" component to file bugs against? 🤞
Attachments
Patch (3.40 KB, patch)
2021-08-16 17:32 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2021-08-16 17:32:26 PDT
Marcos Caceres
Comment 2 2021-08-16 21:03:42 PDT
If it's not too late, this test will also pass now: https://wpt.live/web-share/share-without-user-gesture.https.html It's similar to the other test, but the other tests actually checks if the activation was consumed.
EWS
Comment 3 2021-08-16 21:32:32 PDT
Committed r281126 (240580@main): <https://commits.webkit.org/240580@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435648 [details].
Radar WebKit Bug Importer
Comment 4 2021-08-16 21:33:24 PDT
Note You need to log in before you can comment on or make changes to this bug.