Bug 229112 - ThreadSanitizer: data races of WTF::String in WebResourceLoadStatisticsStore
Summary: ThreadSanitizer: data races of WTF::String in WebResourceLoadStatisticsStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-14 12:52 PDT by David Kilzer (:ddkilzer)
Modified: 2021-08-15 13:05 PDT (History)
9 users (show)

See Also:

Attachments
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite (68.46 KB, text/plain)
2021-08-14 12:58 PDT, David Kilzer (:ddkilzer) 		no flags Details
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite (68.05 KB, text/plain)
2021-08-14 12:58 PDT, David Kilzer (:ddkilzer) 		no flags Details
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply() (6.50 KB, text/plain)
2021-08-14 12:59 PDT, David Kilzer (:ddkilzer) 		no flags Details
Patch v1 (6.26 KB, patch)
2021-08-14 13:13 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-08-14 12:52:35 PDT 
ThreadSanitizer: data races for WTF::String in WebResourceLoadStatisticsStore.

The races occur in postTask() in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() for both AttributionDestinationSite and SourceSite, and in postTaskReply() in WebResourceLoadStatisticsStore::privateClickMeasurementToString().
Comment 1 Radar WebKit Bug Importer 2021-08-14 12:52:54 PDT 
<rdar://problem/81940951>
Comment 2 David Kilzer (:ddkilzer) 2021-08-14 12:58:09 PDT 
Created attachment 435544 [details]
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite
Comment 3 David Kilzer (:ddkilzer) 2021-08-14 12:58:39 PDT 
Created attachment 435545 [details]
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite
Comment 4 David Kilzer (:ddkilzer) 2021-08-14 12:59:26 PDT 
Created attachment 435546 [details]
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply()
Comment 5 David Kilzer (:ddkilzer) 2021-08-14 13:13:23 PDT 
Created attachment 435547 [details]
Patch v1
Comment 6 Kate Cheney 2021-08-14 13:38:54 PDT 
Comment on attachment 435547 [details]
Patch v1

r=me
Comment 7 EWS 2021-08-15 13:05:35 PDT 
Committed r281066 (240527@main): <https://commits.webkit.org/240527@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435547 [details].