Bug 229110 - [WebXR] A session with only one view should cover the full screen
Summary: [WebXR] A session with only one view should cover the full screen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-14 12:22 PDT by Dean Jackson
Modified: 2021-08-20 12:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2021-08-14 12:26 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (23.81 KB, patch)
2021-08-17 14:57 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-08-14 12:22:37 PDT 
[WebXR] A session with only one view should cover the full screen
Comment 1 Radar WebKit Bug Importer 2021-08-14 12:23:17 PDT 
<rdar://problem/81940621>
Comment 2 Dean Jackson 2021-08-14 12:26:23 PDT 
Created attachment 435542 [details]
Patch
Comment 3 Ada Chan 2021-08-15 00:46:17 PDT 
Comment on attachment 435542 [details]
Patch

Looks good!
Comment 4 Dean Jackson 2021-08-17 14:57:12 PDT 
Created attachment 435714 [details]
Patch
Comment 5 Tim Horton 2021-08-17 16:14:05 PDT 
Comment on attachment 435714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435714&action=review

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:327
> +    if (m_session->mode() == XRSessionMode::ImmersiveVr && m_session->views().size() > 1) {

Odd that "number of views is > 1" then goes around and assumes it's 2. I guess we won't need WebXR for spiders any time soon.

> LayoutTests/http/wpt/webxr/resources/webxr_test_constants_single_view.js:150
> +  supportsImmersive: true,

This file is fairly chaotic indentationwise (as are the others)
Comment 6 Dean Jackson 2021-08-20 12:42:51 PDT 
Committed r281331 (240748@main): <https://commits.webkit.org/240748@main>