WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229105
[IFC][Integration] Walk the box tree to update the replaced content location
https://bugs.webkit.org/show_bug.cgi?id=229105
Summary
[IFC][Integration] Walk the box tree to update the replaced content location
zalan
Reported
2021-08-13 20:08:51 PDT
and not the run list. it's faster.
Attachments
Patch
(3.62 KB, patch)
2021-08-13 20:13 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(3.63 KB, patch)
2021-08-14 05:21 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(3.39 KB, patch)
2021-08-20 15:40 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2021-08-13 20:13:15 PDT
Created
attachment 435534
[details]
Patch
Antti Koivisto
Comment 2
2021-08-14 04:58:46 PDT
Comment on
attachment 435534
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=435534&action=review
> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:66 > + const BoxAndRendererList& boxAndRendererList() { return m_boxes; }
function should be const too
Antti Koivisto
Comment 3
2021-08-14 05:00:32 PDT
Comment on
attachment 435534
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=435534&action=review
> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:65 > + using BoxAndRendererList = Vector<BoxAndRenderer, 1>;
This is probably not needed, I think you can do const auto& boxAndRendererList() const { return m_boxes; }
zalan
Comment 4
2021-08-14 05:21:34 PDT
Created
attachment 435537
[details]
Patch
zalan
Comment 5
2021-08-20 15:40:49 PDT
Created
attachment 436037
[details]
Patch
Radar WebKit Bug Importer
Comment 6
2021-08-20 20:09:22 PDT
<
rdar://problem/82195667
>
EWS
Comment 7
2021-08-20 20:16:28 PDT
Committed
r281361
(
240776@main
): <
https://commits.webkit.org/240776@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 436037
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug