Bug 229105 - [IFC][Integration] Walk the box tree to update the replaced content location
Summary: [IFC][Integration] Walk the box tree to update the replaced content location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-13 20:08 PDT by zalan
Modified: 2021-08-20 20:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2021-08-13 20:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2021-08-14 05:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2021-08-20 15:40 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-08-13 20:08:51 PDT 
and not the run list. it's faster.
Comment 1 zalan 2021-08-13 20:13:15 PDT 
Created attachment 435534 [details]
Patch
Comment 2 Antti Koivisto 2021-08-14 04:58:46 PDT 
Comment on attachment 435534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435534&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:66
> +    const BoxAndRendererList& boxAndRendererList() { return m_boxes; }

function should be const too
Comment 3 Antti Koivisto 2021-08-14 05:00:32 PDT 
Comment on attachment 435534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435534&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:65
> +    using BoxAndRendererList = Vector<BoxAndRenderer, 1>;

This is probably not needed, I think you can do

const auto& boxAndRendererList() const { return m_boxes; }
Comment 4 zalan 2021-08-14 05:21:34 PDT 
Created attachment 435537 [details]
Patch
Comment 5 zalan 2021-08-20 15:40:49 PDT 
Created attachment 436037 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2021-08-20 20:09:22 PDT 
<rdar://problem/82195667>
Comment 7 EWS 2021-08-20 20:16:28 PDT 
Committed r281361 (240776@main): <https://commits.webkit.org/240776@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436037 [details].