Bug 229103 – [LFC][IFC] Add support for out-of-flow box static positioning

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

e.g. https://www.w3.org/TR/CSS22/visudet.html#abs-non-replaced-height

For the purposes of this section and the next, the term "static position" (of an element) refers, roughly, to the position an element would have had in the normal flow. More precisely, the static position for 'top' is the distance from the top edge of the containing block to the top margin edge of a hypothetical box that would have been the first box of the element if its specified 'position' value had been 'static' and its specified 'float' had been 'none' and its specified 'clear' had been 'none'. (Note that due to the rules in section 9.7 this might require also assuming a different computed value for 'display'.) The value is negative if the hypothetical box is above the containing block.

[zalan]

Created attachment 435531 [details]
Patch

[Antti Koivisto]

Comment on attachment 435531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435531&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:260
> +    // Instead we figure out this static position after the inline layout by looking at the previous sibling (or parent) box's geometry and

Are there any cases where we should be looking for the next siblings box?

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:281
> +                // FIXME: In very rare cases, the previous box's content might have been completely collapsed and left us with no run.

I suppose we'll need the previous run-generating box.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 435531 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435531&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:260
> > +    // Instead we figure out this static position after the inline layout by looking at the previous sibling (or parent) box's geometry and
> 
> Are there any cases where we should be looking for the next siblings box?
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:281
> > +                // FIXME: In very rare cases, the previous box's content might have been completely collapsed and left us with no run.
> 
> I suppose we'll need the previous run-generating box.
Yeah, that's exactly what we need.

[zalan]

Created attachment 435553 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/82193466>

[zalan]

Created attachment 436118 [details]
Patch

[zalan]

Created attachment 436130 [details]
Patch

[EWS]

Committed r281424 (240814@main): <https://commits.webkit.org/240814@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436130 [details].