Bug 229102 - Add logging for failure in getting network process connection
Summary: Add logging for failure in getting network process connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-13 16:49 PDT by Sihui Liu
Modified: 2021-08-16 11:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.34 KB, patch)
2021-08-13 16:54 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (10.34 KB, patch)
2021-08-14 20:18 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (10.34 KB, patch)
2021-08-15 13:44 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-08-13 16:49:23 PDT 
...
Comment 1 Sihui Liu 2021-08-13 16:54:23 PDT 
Created attachment 435526 [details]
Patch
Comment 2 Sihui Liu 2021-08-14 20:18:49 PDT 
Created attachment 435556 [details]
Patch
Comment 3 Sihui Liu 2021-08-15 13:44:17 PDT 
Created attachment 435571 [details]
Patch
Comment 4 Geoffrey Garen 2021-08-16 09:59:33 PDT 
Comment on attachment 435571 [details]
Patch

r=me
Comment 5 Chris Dumez 2021-08-16 10:00:07 PDT 
Comment on attachment 435571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435571&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1736
> +                if (!os_variant_allows_internal_security_policies("com.apple.WebKit"))

What is the purpose of this?
Comment 6 Sihui Liu 2021-08-16 10:28:18 PDT 
Comment on attachment 435571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435571&action=review

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1736
>> +                if (!os_variant_allows_internal_security_policies("com.apple.WebKit"))
> 
> What is the purpose of this?

To crash UI process and collect logs only in internal OSs, so we can keep track of crash rate in public OSs.
Comment 7 EWS 2021-08-16 11:27:25 PDT 
Committed r281096 (240555@main): <https://commits.webkit.org/240555@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435571 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-16 11:28:25 PDT 
<rdar://problem/81990503>