Bug 229100 – Use Vector<SandboxExtension::Handle> instead of SandboxExtension::HandleArray

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Use Vector<SandboxExtension::Handle> instead of SandboxExtension::HandleArray

[Alex Christensen]

Created attachment 435520 [details]
Patch

[Chris Dumez]

Comment on attachment 435520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435520&action=review

r=me

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:428
> +bool SandboxExtension::consumePermanently(const Vector<SandboxExtension::Handle>& handleArray)

Wouldn't `const Vector<Handle>&` work?

> Source/WebKit/Shared/SandboxExtension.h:127
> +inline auto SandboxExtension::createReadOnlyHandlesForFiles(ASCIILiteral, const Vector<String>&) -> Vector<Handle> { return { }; }

Do we need the auto return value here? Wouldn't `Vector<Handle>` as return value work here since we're in the class scope?

[Alex Christensen]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 435520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435520&action=review
> 
> r=me
> 
> > Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:428
> > +bool SandboxExtension::consumePermanently(const Vector<SandboxExtension::Handle>& handleArray)
> 
> Wouldn't `const Vector<Handle>&` work?
Yes.

> > Source/WebKit/Shared/SandboxExtension.h:127
> > +inline auto SandboxExtension::createReadOnlyHandlesForFiles(ASCIILiteral, const Vector<String>&) -> Vector<Handle> { return { }; }
> 
> Do we need the auto return value here? Wouldn't `Vector<Handle>` as return
> value work here since we're in the class scope?
No, only trailing return values are in the class scope.

[Alex Christensen]

Created attachment 435896 [details]
Patch

[EWS]

Committed r281277 (240702@main): <https://commits.webkit.org/240702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435896 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82145920>

[Wenson Hsieh]

Reopening to attach new patch.

[Wenson Hsieh]

Created attachment 435933 [details]
Fix internal build?

[EWS]

Committed r281289 (240713@main): <https://commits.webkit.org/240713@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435933 [details].