Bug 229094 – REGRESSION: [ iOS ] 5 TestWebKitAPI.WebpagePreferences.* api tests are flaky timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayEnabled
TestWebKitAPI.WebpagePreferences.WebsitePoliciesUserInterferenceWithPlaying
TestWebKitAPI.WebpagePreferences.WebsitePoliciesUpdates
TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithoutInterference
TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithUserGesture

Are flaky timing out on iOS 14 E Simulator. 

History: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayEnabled&test=TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithUserGesture&test=TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithoutInterference&test=TestWebKitAPI.WebpagePreferences.WebsitePoliciesUpdates&test=TestWebKitAPI.WebpagePreferences.WebsitePoliciesUserInterferenceWithPlaying

stdio: https://build.webkit.org/#/builders/45/builds/1794/steps/17/logs/stdio

Looking at the history, it looks like the flaky timeout has started at https://trac.webkit.org/changeset/279835/webkit because the tests were consistently crashing for a short period of time before they started flaky timing out and this change https://trac.webkit.org/changeset/279679/webkit fixed the crash.

[Radar WebKit Bug Importer]

<rdar://problem/81915299>

[Chris Dumez]

I don't think the regression point is correct.

r279835 got reverted in r279840 and yet the tests were still flaky after that.

You are right. It is r279840.

[Chris Dumez]

(In reply to ayumi_kojima from comment #3)
> You are right. It is r279840.

No, this doesn't make sense either since r279840 is a simple revert of r279835.

Okay, now I understand it. I will try bisect it and research more. Thanks Chris!

[Eric Hutchison]

Reproduction: 

1) TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayEnabled timeout was reproduced on r279831 using run-api-tests --iOS-simulator --release TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayEnabled. The test passed on r 279866 using the same command. There are no available spades between those revisions to test on.

2) TestWebKitAPI.WebpagePreferences.WebsitePoliciesUserInterferenceWithPlaying
TestWebKitAPI.WebpagePreferences.WebsitePoliciesUpdates
TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithoutInterference
TestWebKitAPI.WebpagePreferences.WebsitePoliciesPlayingWithUserGesture:
each of these tests passed on r279831 and r279866 with the same command as above. Was unable to reproduce the timeout on these tests.

[Eric Hutchison]

Attempted to reproduce timeouts using run-api-tests --iterations 100 --iOS-simulator --no-build tesname on r281989 and r281920. Unable to reproduce.

[Alex Christensen]

Created attachment 438491 [details]
Patch

[EWS]

Committed r282678 (241819@main): <https://commits.webkit.org/241819@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438491 [details].

[Eric Hutchison]

Patch applied disables test; issue is not resolved. Reopening bug.

[Alex Christensen]

Created attachment 447672 [details]
Patch

[EWS]

Committed r287298 (245450@main): <https://commits.webkit.org/245450@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447672 [details].