In top layer: display: contents -> display: block; position: static/relative/sticky -> position: absolute;
Created attachment 435506 [details] Patch
Comment on attachment 435506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435506&action=review > Source/WebCore/style/StyleAdjuster.cpp:583 > + if (!m_element && style.styleType() != PseudoId::Before && style.styleType() != PseudoId::After) { Would be nice to wrap the PseudoId::Before & PseudoId::After check in a function that is named using a spec-related term; maybe put it as a static function in some pseudo-related code.
Created attachment 435522 [details] Patch
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 435506 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435506&action=review > > > Source/WebCore/style/StyleAdjuster.cpp:583 > > + if (!m_element && style.styleType() != PseudoId::Before && style.styleType() != PseudoId::After) { > > Would be nice to wrap the PseudoId::Before & PseudoId::After check in a > function that is named using a spec-related term; maybe put it as a static > function in some pseudo-related code. non-before/after pseudo element? not sure. I left it as it was, not sure how to improve it really.
(In reply to Tim Nguyen (:ntim) from comment #4) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 435506 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=435506&action=review > > > > > Source/WebCore/style/StyleAdjuster.cpp:583 > > > + if (!m_element && style.styleType() != PseudoId::Before && style.styleType() != PseudoId::After) { > > > > Would be nice to wrap the PseudoId::Before & PseudoId::After check in a > > function that is named using a spec-related term; maybe put it as a static > > function in some pseudo-related code. > > non-before/after pseudo element? not sure. I left it as it was, not sure how > to improve it really. hmm maybe non tree-abiding pseudo element
(In reply to Tim Nguyen (:ntim) from comment #5) > (In reply to Tim Nguyen (:ntim) from comment #4) > > (In reply to Simon Fraser (smfr) from comment #2) > > > Comment on attachment 435506 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=435506&action=review > > > > > > > Source/WebCore/style/StyleAdjuster.cpp:583 > > > > + if (!m_element && style.styleType() != PseudoId::Before && style.styleType() != PseudoId::After) { > > > > > > Would be nice to wrap the PseudoId::Before & PseudoId::After check in a > > > function that is named using a spec-related term; maybe put it as a static > > > function in some pseudo-related code. > > > > non-before/after pseudo element? not sure. I left it as it was, not sure how > > to improve it really. > > hmm maybe non tree-abiding pseudo element Well, this seems inconsistent across browsers, so I filed a spec issue: https://github.com/w3c/csswg-drafts/issues/6518 Will leave this unchanged for now (though there are improvements that could be done to match other browsers).
Created attachment 435886 [details] Patch
Committed r281252 (240688@main): <https://commits.webkit.org/240688@main>
<rdar://problem/82133421>