Bug 22909 – The JSC JIT doesn't yet even run "Hello, world" on x86-64.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Make the JIT run a simple "Hello, world" on x86-64.

[Gavin Barraclough]

Created attachment 26110 [details]
The patch

No change to 32-bit, and not yet enabled by default on 64-bit.

[Sam Weinig]

Comment on attachment 26110 [details]
The patch

> +    typedef struct
> +    {
> +        void* first;
> +        void* second;
> +    } VoidPtrPair;

This should use our normal struct format. You can fix the union at the same time if you like.

> +#if PLATFORM(X86_64)
> +            // Temporary measure - for now, this will force all arguments onto the stack (regparm(0) does not appear to have any effect).
> +            // We can allow register passing here, and move the writes of these values into the trampoline.
> +            void*, void*, void*, void*, void*, void*,

Ick!  Please add a FIXME preferably with a bug number.

>  #define ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS 1
>  #define ENABLE_JIT_OPTIMIZE_ARITHMETIC 1
>  #endif
> +#if !defined(ENABLE_JIT) && PLATFORM(X86_64) && PLATFORM(MAC) && 0
> +#define ENABLE_JIT 1
> +#define WTF_USE_CTI_ARGUMENT 1
> +#endif

Please remove the && 0 and instead set ENABLE_JIT and WTF_USE_CTI_ARGUMENT to 0.

r=me

[Gavin Barraclough]

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/interpreter/Interpreter.cpp
Sending        JavaScriptCore/interpreter/Interpreter.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JIT.h
Sending        JavaScriptCore/jit/JITCall.cpp
Sending        JavaScriptCore/jit/JITInlineMethods.h
Sending        JavaScriptCore/wtf/Platform.h
Transmitting file data .........
Committed revision 39370.