Bug 229074 - [css-flexbox] Add support for start & end css-align-3 positional alignment properties
Summary: [css-flexbox] Add support for start & end css-align-3 positional alignment pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-13 08:08 PDT by Sergio Villar Senin
Modified: 2021-09-01 01:36 PDT (History)
14 users (show)

See Also:

Attachments
Patch (31.28 KB, patch)
2021-08-13 08:47 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (32.17 KB, patch)
2021-08-13 10:18 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (32.20 KB, patch)
2021-08-16 02:11 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (32.26 KB, patch)
2021-08-31 03:00 PDT, Sergio Villar Senin 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-08-13 08:08:01 PDT 
[css-flexbox] Add initial support for css-align-3 positional alignment properties
Comment 1 Sergio Villar Senin 2021-08-13 08:47:40 PDT 
Created attachment 435484 [details]
Patch
Comment 2 Sergio Villar Senin 2021-08-13 09:00:36 PDT 
Comment on attachment 435484 [details]
Patch

not ready for review yet
Comment 3 Sergio Villar Senin 2021-08-13 10:18:12 PDT 
Created attachment 435490 [details]
Patch
Comment 4 Sergio Villar Senin 2021-08-16 02:11:01 PDT 
Created attachment 435580 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-08-20 08:08:17 PDT 
<rdar://problem/82170743>
Comment 6 Sergio Villar Senin 2021-08-26 07:25:03 PDT 
Ping reviewers. It'd be nice to get this in as it's blocking another two other patches that also fix tons of tests.
Comment 7 Sergio Villar Senin 2021-08-26 07:25:28 PDT 
(In reply to Sergio Villar Senin from comment #6)
> Ping reviewers. It'd be nice to get this in as it's blocking another two
> other patches that also fix tons of tests.

Well and provide additional functionality to WebKit of course :)
Comment 8 Simon Fraser (smfr) 2021-08-26 10:37:53 PDT 
Comment on attachment 435580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435580&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1547
> +        ASSERT_NOT_REACHED("%d alignmentForChild should have transformed this position value to something we handle below.", static_cast<uint64_t>(position));

Formatting for uint64_t would be %llu. For %d, use int.
Comment 9 Sergio Villar Senin 2021-08-31 03:00:06 PDT 
Created attachment 436863 [details]
Patch
Comment 10 Sergio Villar Senin 2021-09-01 01:36:05 PDT 
Committed r281840 (241173@main): <https://commits.webkit.org/241173@main>