Bug 229067 – [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Lauro Moura]

/WPE/TestWebExtensions
        /webkit/WebKitWebView/web-process-crashed

Output:

  /webkit/WebKitWebView/web-process-crashed:                          FAIL
WPE-FDO-FATAL-WARNING: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side

(/app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebExtensions:778): WPE-FDO-WARNING **: 06:40:11.689: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side



In the release bot, the first failure was in the build #2602 for identifier 240345@main. Since this revision, it failed 31 out of 41 runs.

Locally:

Laptop: 4 fails in 20 runs
Desktop: 7 fails in 20 runs

In a manual build outside Flatpak, no errors in 10 runs.

[Carlos Garcia Campos]

I guess that's expected to happen in case of web process crash, so maybe we can just make warnings non fatal at that point or not use g_warning in wpe-fdo

[Lauro Moura]

Created attachment 435477 [details]
Patch

[Lauro Moura]

(In reply to Carlos Garcia Campos from comment #1)
> I guess that's expected to happen in case of web process crash, so maybe we
> can just make warnings non fatal at that point or not use g_warning in
> wpe-fdo

Indeed. With this patch, it's consistently passing.

[Lauro Moura]

Created attachment 435478 [details]
Patch with updated expectations

[Carlos Garcia Campos]

Comment on attachment 435478 [details]
Patch with updated expectations

View in context: https://bugs.webkit.org/attachment.cgi?id=435478&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:166
> +    Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
>      g_main_loop_run(test->m_mainLoop);
> +    Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);

Ok, I think we should still check if we can remove the g_warning in wpe-fdo, because thi might hide other warnings happening.

[EWS]

Committed r281015 (240505@main): <https://commits.webkit.org/240505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435478 [details].