Bug 229059 - [Web App Manifest] Always fetch the first manifest if provided
Summary: [Web App Manifest] Always fetch the first manifest if provided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-12 17:05 PDT by Devin Rousso
Modified: 2021-09-03 14:49 PDT (History)
18 users (show)

See Also:

Attachments
Patch (21.66 KB, patch)
2021-08-12 17:20 PDT, Devin Rousso 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (21.66 KB, patch)
2021-08-12 17:51 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (31.21 KB, patch)
2021-08-16 15:39 PDT, Devin Rousso 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch (30.49 KB, patch)
2021-09-02 15:49 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-08-12 17:05:20 PDT 
Right now, WebKit only fetches the web app manifest when `-[WKWebView _getApplicationManifestWithCompletionHandler:]` is called.  We should always fetch it.
Comment 1 Devin Rousso 2021-08-12 17:20:32 PDT 
Created attachment 435457 [details]
Patch
Comment 2 Devin Rousso 2021-08-12 17:51:23 PDT 
Created attachment 435459 [details]
Patch
Comment 3 Devin Rousso 2021-08-16 15:39:54 PDT 
Created attachment 435634 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-08-19 17:06:21 PDT 
<rdar://problem/82148333>
Comment 5 Brent Fulgham 2021-09-02 09:53:17 PDT 
Comment on attachment 435634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435634&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=229059

<rdar://82148333>

> Source/WebCore/html/HTMLLinkElement.cpp:514
> +    auto media = MediaQuerySet::create(m_media, MediaQueryParserContext(document()));

Why did you remove the LOG statement?

> Source/WebCore/loader/DocumentLoader.cpp:1566
> +        if (link.href().isEmpty() || !link.href().isValid())

HTMLLinkElement::href() looks kind of expensive. Would be good to only build it once rather than three times.
Comment 6 Devin Rousso 2021-09-02 15:49:55 PDT 
Created attachment 437205 [details]
Patch
Comment 7 EWS 2021-09-03 14:49:02 PDT 
Committed r282026 (241330@main): <https://commits.webkit.org/241330@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437205 [details].