Bug 229050 - [GTK][WPE] Test fast/canvas/webgl/shader-with-comma-op.html and fast/canvas/webgl/shader-with-struct-array.html fail since they were added
Summary: [GTK][WPE] Test fast/canvas/webgl/shader-with-comma-op.html and fast/canvas/w...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-12 13:31 PDT by Carlos Alberto Lopez Perez
Modified: 2021-08-13 14:57 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2021-08-12 13:31:38 PDT
Test fast/canvas/webgl/shader-with-comma-op.html fails since it was added on r279656 on GTK and WPE.

The text failure is:

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-comma-op-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-comma-op-actual.txt
@@ -1,12 +1,16 @@
+CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays
+CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays
+CONSOLE MESSAGE: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays
 Tests compiling programs that use the 'sequence' operator..
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS getError was expected value: NO_ERROR : no error for using comma operator with void function
-PASS getError was expected value: NO_ERROR : no error for using comma operator with non-void  function
-PASS getError was expected value: NO_ERROR : no error for using comma operator with standard type
+FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with void function
+FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with non-void  function
+FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : no error for using comma operator with standard type
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
Comment 1 Carlos Alberto Lopez Perez 2021-08-12 13:40:05 PDT
Also, likely related to the same issue, test fast/canvas/webgl/shader-with-struct-array.html fails since it was added on r279968 on GTK and WPE


The text failure is:

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-actual.txt
@@ -1,10 +1,11 @@
+CONSOLE MESSAGE: TypeError: null is not an object (evaluating 'gl.createShader')
 Tests that program compiling/linking with a struct-array construct.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS getError was expected value: NO_ERROR : no error for struct array in program
-PASS successfullyParsed is true
+FAIL successfullyParsed should be true. Was false.
+Some tests failed.
 
 TEST COMPLETE
Comment 2 Carlos Alberto Lopez Perez 2021-08-12 13:42:04 PDT
This two tests seems related to the Metal backend of WebGL. On Linux Metal is not supported.

I wonder if the output they give is expected and we should simply skip them or there is something to fix on the WebKit Linux/WebGL backend?
Comment 3 Carlos Alberto Lopez Perez 2021-08-12 18:29:16 PDT
Expectations updated on r281002
Comment 4 Kyle Piddington 2021-08-13 14:57:17 PDT
As a heads up, these tests were added to verify fixing the following two samples:
https://bugs.webkit.org/show_bug.cgi?id=226865
Shader-with-struct-array: https://zynaps.com/content/photon/


Shader with comma-op
https://bugs.webkit.org/show_bug.cgi?id=227723
https://jsfiddle.net/9p1f3t5r/2/