Bug 229045 – Expose [WebAccessibilityObjectWrapper lineRectsAndText] on MacOS.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Expose [WebAccessibilityObjectWrapper lineRectsAndText] on MacOS.

[Andres Gonzalez]

<rdar://81819301>

[Andres Gonzalez]

Created attachment 435541 [details]
Patch

[Andres Gonzalez]

Created attachment 435563 [details]
Patch

Skip test on mac-wk1 and win.

[Andres Gonzalez]

The style error is that the second line in:

        return @{ @"rect": [NSValue valueWithRect:[self convertRectToSpace:FloatRect(line.first) space:AccessibilityConversionSpace::Screen]],
                  @"text": line.second.get() };

Has an odd number of indent spaces to align the two entries in the dictionary. I believe it makes it more readable this way, so left it as is.

[Andres Gonzalez]

The win test failures are unrelated to this patch.

[chris fleizach]

Comment on attachment 435563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435563&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:341
> +    // rdar://7980318 if we start a call, then block in WebThreadLock(), then we're dealloced on another, thread, we could

if we're going to move this method around I feel like maybe we should combine it together. it's about the same except the WebThreadLock part which could be conditionalized

We probably need to leave the _prepareAXCall method itself as a pass through until we update the bundle side

[Andres Gonzalez]

(In reply to chris fleizach from comment #6)
> Comment on attachment 435563 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435563&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:341
> > +    // rdar://7980318 if we start a call, then block in WebThreadLock(), then we're dealloced on another, thread, we could
> 
> if we're going to move this method around I feel like maybe we should
> combine it together. it's about the same except the WebThreadLock part which
> could be conditionalized
> 
> We probably need to leave the _prepareAXCall method itself as a pass through
> until we update the bundle side

Agree. I added this comment to the base header:

// FIXME: unified these two methods into one.
#if PLATFORM(MAC)
// Updates the underlying object and accessibility hierarchy , and returns the
// corresponding AXCoreObject.
- (WebCore::AXCoreObject*)updateObjectBackingStore;
#else
- (BOOL)_prepareAccessibilityCall;
#endif

I'll make that change separate. The request was not to make any cleanup/rework changes until branching to avoid possible merge/cherry picking conflicts, so I tried to keep this change to the minimum possible.

[EWS]

Committed r281108 (240567@main): <https://commits.webkit.org/240567@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435563 [details].