Bug 229044 - Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
Summary: Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-12 11:06 PDT by Alex Christensen
Modified: 2021-08-12 15:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2021-08-12 11:07 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2021-08-12 11:41 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-08-12 11:06:56 PDT 
Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
Comment 1 Alex Christensen 2021-08-12 11:07:48 PDT 
Created attachment 435436 [details]
Patch
Comment 2 Geoffrey Garen 2021-08-12 11:22:15 PDT 
Comment on attachment 435436 [details]
Patch

r=me
Comment 3 Chris Dumez 2021-08-12 11:22:56 PDT 
Comment on attachment 435436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435436&action=review

> Source/WebCore/page/Performance.cpp:281
>      ASSERT(scriptExecutionContext());

I don't think this assertion holds anymore. You probably want to switch that to an early return. The HTML event loop can fire tasks after the script execution context is gone.
Comment 4 Alex Christensen 2021-08-12 11:41:04 PDT 
Created attachment 435437 [details]
Patch
Comment 5 EWS 2021-08-12 12:25:11 PDT 
Committed r280977 (240480@main): <https://commits.webkit.org/240480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435437 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-12 12:26:24 PDT 
<rdar://problem/81862383>
Comment 7 Alex Christensen 2021-08-12 15:27:28 PDT 
Reverted in r280988
Comment 8 Alex Christensen 2021-08-12 15:27:52 PDT 
The change in http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html definitely looks related.