Bug 229042 - Support animations on ::backdrop
Summary: Support animations on ::backdrop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on: 230002 230008
Blocks: dialog-element 227801
  Show dependency treegraph
 
Reported: 2021-08-12 10:37 PDT by Tim Nguyen (:ntim)
Modified: 2021-09-08 00:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.92 KB, patch)
2021-09-07 10:04 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2021-09-07 10:09 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-08-12 10:37:05 PDT
::backdrop should be animatable
Comment 1 Radar WebKit Bug Importer 2021-08-19 10:38:17 PDT
<rdar://problem/82132016>
Comment 2 Tim Nguyen (:ntim) 2021-09-07 10:04:45 PDT
Created attachment 437519 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-09-07 10:09:14 PDT
Created attachment 437520 [details]
Patch
Comment 4 EWS Watchlist 2021-09-07 10:10:21 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Antoine Quint 2021-09-08 00:23:17 PDT
Comment on attachment 437520 [details]
Patch

We should probable reference bug 230008 somewhere about the ref test failure due to opacity animations applying to the <dialog> itself.
Comment 6 Tim Nguyen (:ntim) 2021-09-08 00:24:43 PDT
(In reply to Antoine Quint from comment #5)
> Comment on attachment 437520 [details]
> Patch
> 
> We should probable reference bug 230008 somewhere about the ref test failure
> due to opacity animations applying to the <dialog> itself.

it's referenced in LayoutTests/TestExpectations, and it's a dependency of this bug :)
Comment 7 EWS 2021-09-08 00:48:37 PDT
Committed r282133 (241430@main): <https://commits.webkit.org/241430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437520 [details].