WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
229033
Cherry-pick ANGLE: Fix translator fuzzer
https://bugs.webkit.org/show_bug.cgi?id=229033
Summary
Cherry-pick ANGLE: Fix translator fuzzer
Kimmo Kinnunen
Reported
2021-08-12 04:06:13 PDT
From 2aa4f7e521a2bf0d84706403f56886047768ce3d Mon Sep 17 00:00:00 2001 From: Shahbaz Youssefi <
syoussefi@chromium.org
> Date: Fri, 8 Jan 2021 16:35:29 -0500 Subject: [PATCH] Fix translator fuzzer Since some ASTs are now disabled on certain conditions, this change lets the fuzzer know when it has generated invalid translator options. Makes it easier to change the file.
Attachments
Patch
(6.07 KB, patch)
2021-08-12 04:08 PDT
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Patch
(5.88 KB, patch)
2021-08-12 05:15 PDT
,
Kimmo Kinnunen
kbr
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2021-08-12 04:08:54 PDT
Created
attachment 435412
[details]
Patch
EWS Watchlist
Comment 2
2021-08-12 04:09:46 PDT
Note that there are important steps to take when updating ANGLE. See
https://trac.webkit.org/wiki/UpdatingANGLE
Kimmo Kinnunen
Comment 3
2021-08-12 05:15:30 PDT
Created
attachment 435417
[details]
Patch
Kenneth Russell
Comment 4
2021-08-13 15:03:48 PDT
Comment on
attachment 435417
[details]
Patch Since this is a cherry-pick, looks fine if you want to merge this - but in general I would prefer if we collaborated on finishing the upstreaming of the direct-to-Metal backend so that we can just roll ANGLE forward in WebKit, which should fix these fuzzer targets here. r+
Kimmo Kinnunen
Comment 5
2021-08-16 01:23:23 PDT
Thanks for checking this out. The cherry-pick is pointless if the blocking bug is r-.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug