Bug 229013 - Fix some `NSAttributedString` inconsistencies between WK1 and WK2
Summary: Fix some `NSAttributedString` inconsistencies between WK1 and WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-11 14:50 PDT by Devin Rousso
Modified: 2021-08-12 11:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.36 KB, patch)
2021-08-11 15:02 PDT, Devin Rousso 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.35 KB, patch)
2021-08-11 15:32 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-08-11 14:50:05 PDT 
`NSAttributedString` now uses WK2, which has caused us to discover some bugs :P
Comment 1 Devin Rousso 2021-08-11 14:50:19 PDT 
<rdar://problem/81215696>
Comment 2 Devin Rousso 2021-08-11 15:02:05 PDT 
Created attachment 435378 [details]
Patch
Comment 3 Timothy Hatcher 2021-08-11 15:05:02 PDT 
Comment on attachment 435378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435378&action=review

> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:155
> +        [configuration preferences]._defaultFontSize = 12;

configuration.preferences._defaultFontSize = 12;
Comment 4 Devin Rousso 2021-08-11 15:05:44 PDT 
Comment on attachment 435378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435378&action=review

>> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:155
>> +        [configuration preferences]._defaultFontSize = 12;
> 
> configuration.preferences._defaultFontSize = 12;

we can't cause it's a `RetainPtr` 😅
Comment 5 Devin Rousso 2021-08-11 15:32:16 PDT 
Created attachment 435379 [details]
Patch
Comment 6 EWS 2021-08-12 11:58:54 PDT 
Committed r280973 (240477@main): <https://commits.webkit.org/240477@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435379 [details].